Turn interface definition and compliance tests into devDependency #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh damn, thanks for the PR @robertkiel |
vasco-santos
suggested changes
Jul 22, 2021
package.json
Outdated
| @@ -151,6 +149,8 @@ | |||
| "libp2p-delegated-peer-routing": "^0.10.0", | |||
| "libp2p-floodsub": "^0.27.0", | |||
| "libp2p-gossipsub": "^0.10.0", | |||
| "libp2p-interfaces": "^1.0.0", | |||
There was a problem hiding this comment.
interfaces should be a dependency, but the compliance totally a devDep
There was a problem hiding this comment.
It could also make sense to turn aegir into devDependency within libp2p-interfaces-compliance-tests but haven't checked that
robertkiel
pushed a commit
to robertkiel/js-libp2p-mplex
that referenced
this pull request
Jul 22, 2021
This was referenced Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation
When installing latest version of
js-libp2p, it installslibp2p-interfaces-compliance-tests@1.0.0as dependency which itself installaegir@33which is not needed forjs-libp2pto run.Problem
Installing
aegirchanges the way how some modules are resolved by Node.js, hence tools such as Typedoc fail while loading plugins.Solution
Turn dependencies that are only needed for development or releasing NPM packages into devDependencies to make sure they are not installled when installing
js-libp2p. This also reduces the footprint ofjs-libp2pas a dependency.