This repository has been archived by the owner on Feb 26, 2021. It is now read-only.
add filter functionality for multiaddr #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
suggested changes
Mar 12, 2018
There was a problem hiding this comment.
Thanks for the PR @zcstarr. The filter function on PeerInfo should not be just a simple array.filter, but rather an expansion of mafmt -- https://github.com/multiformats/js-mafmt.
src/multiaddr-set.js
Outdated
| @@ -52,6 +52,10 @@ class MultiaddrSet { | |||
| return this._multiaddrs.forEach(fn) | |||
| } | |||
|
|
|||
| filter (fn) { | |||
| return this._multiaddrs.filter(fn) | |||
| } | |||
There was a problem hiding this comment.
This should really use https://github.com/multiformats/js-mafmt
daviddias
reviewed
Mar 14, 2018
package.json
Outdated
| @@ -44,8 +44,9 @@ | |||
| "pre-commit": "^1.2.2" | |||
| }, | |||
| "dependencies": { | |||
| "multiaddr": "^3.0.2", | |||
| "js-mafmt": "^1.0.0", | |||
There was a problem hiding this comment.
@zcstarr the correct module name is mafmt
daviddias
approved these changes
Apr 9, 2018
ghost
removed
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in regards to #7 , it seems like adding a filter capability to multiaddrs in PeerInfo would be a step in the right direction, maybe all that's really needed. Downstream request become something like
For more complex slices it seems as though maybe js-mafmt should expose or/and, so people can define their own valid slices of protocols, then refer to them as needed if that make sense. @diasdavid what do you think, not sure if this is inline with what you had in mind :), open to suggestions thoughts.