Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mangled PRs #5

Closed
dryajov opened this issue May 10, 2018 · 0 comments
Closed

Mangled PRs #5

dryajov opened this issue May 10, 2018 · 0 comments

Comments

@dryajov
Copy link
Member

dryajov commented May 10, 2018

I had a few issues with PRs being mangled (by github?) in this repo. I've reported the issues with github support, but meanwhile #4 seems to be holding up correctly.

What happened:

  • I've rebased some commits in the original PR ( Feat/pull mplex #1) to make it commitlint compliant
  • after pushing to the PR, github auto-closed the PR (claiming it was me), and didn't allow me to reopen it
  • creating a new branch and trying to create a new PR didn't work - github would present me with the old (closed) PR link and wouldn't allow me to create a new PR

How I fixed it:

  • I had to reclone the repo and manually delete the local and remote branches
  • after that I had to rebase the new branch with master, which allowed me to create a new PR
  • however, subsequent attempts to fix commit messages let to the same behavior, which required creating a new branch and PR every time.

I've contacted github support, and left a description of the problem. This has left 3 (#1, #2, #3) mangled PRs behind. Please disregard those. Sorry for the spam everybody.

@dryajov dryajov closed this as completed Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant