Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure we callback on .end #9

Merged
merged 1 commit into from
Mar 15, 2019
Merged

fix: ensure we callback on .end #9

merged 1 commit into from
Mar 15, 2019

Conversation

jacobheun
Copy link
Contributor

If the muxer was already destroyed and .end was called, the callback would never be called since 'close' would not be emitted. This change fixes that by checking the destroyed status of the multiplexer.

@ghost ghost assigned jacobheun Mar 15, 2019
@ghost ghost added the status/in-progress In progress label Mar 15, 2019
@jacobheun jacobheun marked this pull request as ready for review March 15, 2019 11:55
vasco-santos
vasco-santos approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jacobheun jacobheun merged commit 8bd170d into master Mar 15, 2019
@jacobheun jacobheun deleted the fix/already-end branch March 15, 2019 12:30
@ghost ghost removed the status/in-progress In progress label Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

Assignees

@jacobheun jacobheun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobheun @vasco-santos