Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the error to NetworkBehaviour::inject_listened_closed() #1475

Closed
tomaka opened this issue Feb 27, 2020 · 1 comment · Fixed by #1517
Closed

Pass the error to NetworkBehaviour::inject_listened_closed() #1475

tomaka opened this issue Feb 27, 2020 · 1 comment · Fixed by #1517
Labels
difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well

Comments

@tomaka
Copy link
Member

tomaka commented Feb 27, 2020

No description provided.

@tomaka tomaka added difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well labels Feb 27, 2020
@tcharding
Copy link
Contributor

tcharding commented Mar 25, 2020 •
edited
Loading

Taking a punt at this; Typo in issue title, should read: Pass eror to NetworkBehaviour::inject_listener_closed().

Also taking a punt at what is wanted; We want to pass the error, if there was one, from the NetworkEvent::ListenerClosed reason field to the inject_listener_closed() method.

@tcharding tcharding mentioned this issue Mar 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass the error to inject_listener_closed method tcharding/rust-libp2p
2 participants
@tomaka @tcharding