-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: mdns in libp2p #572
Comments
mDNS packets have a size limit so we need to take that into account. Overall, I'd say this sounds like a new spec to me rather than changing the existing one. mDNS is cool but ultimately a not very important discovery mechanism IMO. It would be more useful to push things like #498 forward which allows all connections to benefit from decreased latency until they receive the identify info. |
Reducing the handshake latency is not really interesting on local networks, since the RTT is so small anyway. It matters much more on the public internet. |
Right, that leads us to the same conclusion though :) |
@thomaseizinger I agree with you, I was just adding to your point :) |
I try to understand the proposal #498 |
It is not. It's all explained in #498 (0.5-RTT section). Closing this issue here since there's nothing actionable. |
The current implementation of mDNS in libp2p (go) publish a set of multi addresses.
The multi addresses are not encoded and probably consume more bytes then an encoded version (like the addresses in identity proto)
Does it make sense to publish the identity instead of publishing the plain multi address?
Nice benefit would be, that the peers protocols are known before dialing the peer.
The text was updated successfully, but these errors were encountered: