Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add connectivity tests for circuit v2 #147

Closed
wants to merge 13 commits into from
Closed

feat: add connectivity tests for circuit v2 #147

wants to merge 13 commits into from

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Mar 6, 2023

  • early draft for now
  • static docker compose file and rust v0.51.0 only
  • opening early for others to subscribe to progress
  • not yet ready for review

Fixes #116

@MarcoPolo MarcoPolo self-requested a review March 7, 2023 01:47
marten-seemann
marten-seemann reviewed Mar 7, 2023
View reviewed changes
relay/rust/v0.51.0/ping-version.json Outdated
Comment on lines 10 to 17
"secureChannels": [
"tls",
"noise"
],
"muxers": [
"mplex",
"yamux"
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to test different secure channels and muxers here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, this is just a copy&paste from the existing interop tests.

I suggest a first iteration to not test different transport, security and muxer combinations on the direct connections, though potentially on the relayed connection.

Long term, it would be great to test all of them, maybe using randomness to fight the cardinality explosion, e.g. via property based testing as suggested by @thomaseizinger in #116 (comment).

@mxinden
Copy link
Member Author

mxinden commented Mar 7, 2023

Good news:

Running 1 tests
Running test spec: rust-v0.51.0 <-> rust-v0.51.0 <-> rust-v0.51.0
Finished: rust-v0.51.0 <-> rust-v0.51.0 <-> rust-v0.51.0
0 failures []
Run complete

@MarcoPolo
Copy link
Contributor

Untagging myself for review to tidy up my pending reviews. But please tag me again when this is ready.

@MarcoPolo MarcoPolo removed their request for review May 22, 2023 20:18
@p-shahi p-shahi mentioned this pull request Jun 22, 2023
Open
@mxinden mxinden closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add connectivity tests for circuit v2
3 participants
@mxinden @MarcoPolo @marten-seemann