Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constant Chapter name in player #2850

Closed
3 tasks done
NeeRaj-2401 opened this issue Jan 23, 2023 · 2 comments
Closed
3 tasks done

constant Chapter name in player #2850

NeeRaj-2401 opened this issue Jan 23, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@NeeRaj-2401
Copy link
Contributor

NeeRaj-2401 commented Jan 23, 2023

Steps to reproduce

  1. Play video having chapters
  2. navigate between chapters

Expected behavior

Correct chapter name as in description and dialogue.

Actual behavior

only first chapters name is visible in player

LibreTube version

0.11.1

Android version

Android 12

Other details

also after PR #2848 , in portrait mode when clicking on chapter name. the lanscape mode dialogue is popping up. which was not intended mentioned here

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@NeeRaj-2401 NeeRaj-2401 added the bug Something isn't working label Jan 23, 2023
@NeeRaj-2401
Copy link
Contributor Author

NeeRaj-2401 commented Jan 23, 2023

in short, things to be fixed are

  1. chapter name in player
  2. chapter dialogue pop-up in portrait

@Bnyro
Copy link
Member

Bnyro commented Jan 23, 2023

It was mentioned in Always use the chapters dialog as on title click action, the issue is caused by 93b073a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants