Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double tap to play/pause video improvment #2956

Closed
3 tasks done
NeeRaj-2401 opened this issue Feb 3, 2023 · 2 comments · Fixed by #2961
Closed
3 tasks done

Double tap to play/pause video improvment #2956

NeeRaj-2401 opened this issue Feb 3, 2023 · 2 comments · Fixed by #2961
Labels
bug Something isn't working

Comments

@NeeRaj-2401
Copy link
Contributor

Steps to reproduce

  1. double tap on paused video
  2. again double tap on playing video
WhatsApp.Video.2023-02-03.at.8.20.55.PM.mp4

Expected behavior

double tapping on playing video should pause the video without showing the player controls just like cloudstream.

Actual behavior

pauses the video with showing the player controls

LibreTube version

0.11.1

Android version

Android 12

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@NeeRaj-2401 NeeRaj-2401 added the bug Something isn't working label Feb 3, 2023
@Bnyro Bnyro mentioned this issue Feb 4, 2023
Merged
@NeeRaj-2401
Copy link
Contributor Author

NeeRaj-2401 commented Feb 4, 2023 •
edited
Loading

Updated to latest debug and i think the issue is not completely fixed yet
@faisalcodes can u please look into this

@faisalcodes
Copy link
Contributor

@NeeRaj-2401 I will see.

@faisalcodes faisalcodes mentioned this issue Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve double tap on center of player Bnyro/LibreTube
2 participants
@faisalcodes @NeeRaj-2401