Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Tweaks #3166

Closed
3 tasks done
akano12 opened this issue Feb 23, 2023 · 3 comments · Fixed by #3285
Closed
3 tasks done

Comment Tweaks #3166

akano12 opened this issue Feb 23, 2023 · 3 comments · Fixed by #3285
Labels
enhancement New feature or request

Comments

@akano12
Copy link
Collaborator

akano12 commented Feb 23, 2023

Describe your suggested feature

[First]
When copying a comment that's written on multiple lines (using break lines) the copied text will have <br> tag and the text won't be copied as previewed (instead of copying the text as posted, everything will be on same line separated by <br>tag)

[Second]
There's a small issue when trying to copy a pinned comment, long pressing on pinned comment won't do anything, you'll have to long press either above or below it to copy.

[Third]

Make it possible to mark text from a comment to copy instead of copying the entire comment on long press.

Other details

1.For the <br> issue

For example, when copying text from the image below

Screenshot_20230223_110731_LibreTube

You'll get this:

Thou art gone, thy life hast fled<br>All shall now bewail the dead<br>No more flesh and no more bone<br>No more trouble to bemoan<br>Like a wave along the shore<br>You have passed, you will complain nevermore<br>``<br>The late, late lamented<br>For death can’t be prevented
Nevermore tormented<br>The late, late lamented<br>``<br>No more feast<br>Now rest in peace<br>o more pain<br>You can’t complain<br>No more sighs and no more cries<br>No more fears, no more tears<br>No more laughs

2.For pinned comment issue:

Screen_Recording_20230223_112308_LibreTube.mp4

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Bnyro
Copy link
Member

Bnyro commented Mar 10, 2023

  1. is a duplicate of Clicking comment text doesn't open the replies #3070, everything else should work now.

@Snailhail
Copy link

1: Open comment popup
2. Short hold on comment to begin copy
3. Drag to desired amount
4. Touch prompt to copy

When pulling up a comment you should be able to copy by short pressing It then dragging the selector to the personal amount. Follow by the prompt to copy

Android 14

On 0.21.0 selectable comments from the popup don't work, but description works as intended.

@akano12
Copy link
Collaborator Author

akano12 commented Nov 25, 2023

1: Open comment popup
2. Short hold on comment to begin copy
3. Drag to desired amount
4. Touch prompt to copy

When pulling up a comment you should be able to copy by short pressing It then dragging the selector to the personal amount. Follow by the prompt to copy

Android 14

On 0.21.0 selectable comments from the popup don't work, but description works as intended.

Ye i noticed this too, not sure why it was changed.
Open a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants