Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide button to manually skip SponsporBlock sections in player controls #3914

Closed
3 tasks done
MatsG23 opened this issue Jun 3, 2023 · 5 comments · Fixed by #4099
Closed
3 tasks done

Hide button to manually skip SponsporBlock sections in player controls #3914

MatsG23 opened this issue Jun 3, 2023 · 5 comments · Fixed by #4099
Labels
enhancement New feature or request

Comments

@MatsG23
Copy link

MatsG23 commented Jun 3, 2023

Describe your suggested feature

If you enabled to manually skip sections of a video listed in SponsorBlock (like an advertisement in a video), you will see a button over the video saying "Skip section" as long as you are in a SponsorBlock section. The thing is that if you open the player controls to e.g. leave fullscreen mode, the button to skip a SponsorBlock section you are currently in does not hide.
The player controls are placed in a layer above the "Skip section" button (you will always hit e.g. the fullscreen button instead of the other button overlaying the video).
I think it would make sense to hide the "Skip section" button if the player controls are open because the button is not functional in that moment anyways.

Other details

A probably better option would be to change the UI of the "Skip section" button by, for example, making it a small but clear-to-understand icon button at the top right of the video. I think that, like this, the button to skip a section could stay in place, would fit in the player controls well and remain functional.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@MatsG23 MatsG23 added the enhancement New feature or request label Jun 3, 2023
@SameenAhnaf

This comment was marked as spam.

@MatsG23
Copy link
Author

MatsG23 commented Jun 3, 2023 via email

@Bnyro
Copy link
Member

Bnyro commented Jun 24, 2023

Please share a screenshot or recording to make it easier to understand your current issue.

@MatsG23
Copy link
Author

MatsG23 commented Jun 24, 2023

Screenshot_20230624-210637

See how the "Skip section" button stays in place and conflicts with the player controls.

@Bnyro
Copy link
Member

Bnyro commented Jun 24, 2023

Oh, I see. I think the easiest way to fix it is to just dynamically update the bottom margin when going into full screen mode. Making the button less present is not convenient for users in my eyes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants