Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When exiting full screen, video stops being interactable (if it ended, it starts again) #5215

Closed
3 tasks done
GitThingsDan opened this issue Nov 22, 2023 · 5 comments · Fixed by #5949
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@GitThingsDan
Copy link

GitThingsDan commented Nov 22, 2023

Steps to reproduce

  1. Click on video
  2. Enter fullscreen
  3. Exit fullscreen

Expected behavior

Video should exit fullscreen without interruptions like loading again, or inconveniences like going back some seconds after loading.

Also, it shouldn't have 'visual glitches' like hiding the name of the channel, or stop being interactable.

Actual behavior

Video loads a bit (which should not be necessary if the video had that part already buffered), and then resumes, but it resumes some seconds before the current position.

Also (and maybe more important), it stops being interactable (it seems you still can double tap to pause, go back or forward, but no such icons appear on screen, which makes it very hard to do it), and it stops displaying the channel's name that's below the video.

Finally, if one exits fullscreen when video has already ended, it starts playing again from the beginning (or, as it seems, from last video position that was saved in watch history). This one is very inconvenient when, for example, I just watched a music video and then exit fullscreen.

All in all, very strange behavior.

LibreTube version

0.20.1

Android version

Android 13

Other details

Screen_Recording_20231122_180029_LibreTube_1.mp4

(I apologize for my English.)

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@GitThingsDan GitThingsDan added the bug Something isn't working label Nov 22, 2023
@GitThingsDan GitThingsDan changed the title When exiting fullscreen, video stops being interactable (if it ended, it starts again)... When exiting full screen, video stops being interactable (if it ended, it starts again)... Nov 22, 2023
@GitThingsDan
Copy link
Author

GitThingsDan commented Nov 22, 2023

It seems I didn't check well enough for similar older issues...could this one recently closed (#5162) be related? minimizing the video and back does seem to make the video screen interactable back again...

@akano12
Copy link
Collaborator

akano12 commented Nov 22, 2023

Try and report back with nightly builds

@GitThingsDan
Copy link
Author

GitThingsDan commented Nov 23, 2023

Try and report back with nightly builds

LibreTube 0.20.1 Debug (default settings): everything seems to be OK here

defaultSettings_20231122_210753_LibreTube.Debug.mp4

LibreTube 0.20.1 Debug (my settings):

mySettings_20231122_210058_LibreTube.Debug_1.mp4

According to the screen recordings above, it looks like the problem is within my settings:

libretube-backup-2023-11-22-22_59_48.json

@TryingToUseLinux
Copy link

The setting that is causing this is screen rotation: auto rotate.
It is occuring during switching between landscape and portrait orientation even when you don't enter full screen mode.
The bug occurs in v0.20.0 and 0.20.1, as they have the new landscape player layout.

@GitThingsDan GitThingsDan changed the title When exiting full screen, video stops being interactable (if it ended, it starts again)... When exiting full screen, video stops being interactable (if it ended, it starts again) Feb 16, 2024
@Bnyro
Copy link
Member

Bnyro commented Feb 18, 2024

That the player controls are not responsive is a duplicate of/the same issue as #4161. Please append your findings related to it there.

For the other issue, please test this again with a debug build after #5635. This doesn't fix the issue 100%, but it should already prevent the player from reloading at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants