Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landscape layout used in portrait mode when opening app via 3rd party app while in landscape mode #5401

Closed
3 tasks done
DanielProg39 opened this issue Dec 29, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@DanielProg39
Copy link

Steps to reproduce

  1. Ensure your phone is in landscape mode
  2. Open the link to the video in any 3rd party app

Expected behavior

The video should open in fullscreen mode, touching the screen should bring up the player interface, rotating the phone should open the video in portrait mode player UI, if the player is minimised, rotating the screen to horizontal should do nothing (at least if rotation is not enabled in the settings).

Actual behavior

Touching the screen doesn't bring up the player interface, rotating the phone opens the video in minimised state, if the player is minimised, rotating the screen to horizontal opens the video in full screen. Opening the video in portrait mode from the minimised state completely breaks the UI.

video_2023-12-29_12-26-33.mp4

LibreTube version

Nightly 0.12.1 commit 887d062

Android version

Android 13

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@DanielProg39 DanielProg39 added the bug Something isn't working label Dec 29, 2023
@lu4p
Copy link
Contributor

lu4p commented Jan 10, 2024

I definitely had this happen to me before but didn't know how to reproduce it.

@M00NJ
Copy link

M00NJ commented Jan 11, 2024

Me too. I think it happens sometimes when I switch back from PiP.

@Bnyro Bnyro changed the title Very strange UI and player behaviour Landscape layout used in portrait mode when opening app via 3rd party app while in landscape mode Feb 11, 2024
@abGit9
Copy link
Contributor

abGit9 commented Mar 6, 2024

This is hard to reproduce but there does seem to be an issue when switching between landscape and portrait modes. The exact behavior is hard to peg but there always seems to be a glitch. Sometimes when landscape -> portrait, my video just disappears. Other times, the ui doesn't change it all.

@Bnyro
Copy link
Member

Bnyro commented May 1, 2024

This should be fixed since #5698 - we now wait until the main activity is rendered before loading the video link - during that time Android also properly reacts to LibreTube's request to change the app orientation to landscape / portrait.

@Bnyro Bnyro closed this as completed May 1, 2024
@DanielProg39
Copy link
Author

Yup, this one's gone now 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants