Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding multiple selection to the subscription feed filter #5453

Closed
3 tasks done
ghost opened this issue Jan 6, 2024 · 12 comments · Fixed by #5478
Closed
3 tasks done

Adding multiple selection to the subscription feed filter #5453

ghost opened this issue Jan 6, 2024 · 12 comments · Fixed by #5478
Assignees
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Jan 6, 2024

Describe your suggested feature

Currently in the subscription feed you can filter by selecting only one of the following options: All, Videos, Shorts & Livestreams. As I am only interested in videos and livestreams. I have to switch between those options and sometimes can be annoying. I don't use de "All" option because shorts are included and there are to many of them that it takes time to get to the videos and livestreams.

My suggestion is add a checkbox to each option in the filters, so the user can check the options that he wants to see.

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@ghost ghost added the enhancement New feature or request label Jan 6, 2024
@RafaelsRamos
Copy link
Contributor

RafaelsRamos commented Jan 7, 2024

This suggestion sounds great. I would love to work on this one. Is that fine?

@RafaelsRamos
Copy link
Contributor

A proposal for the UX below, please let me know your thoughts:

proposal.mp4

@SameenAhnaf
Copy link
Collaborator

Merging the options within the same menu as Più recenti would be better as it would make less clutter IMO

@RafaelsRamos
Copy link
Contributor

Do you mean adding these chips to the sort bottomsheet? Thus having sort of a Sort/Filter bottom sheet? 🤔

@SameenAhnaf
Copy link
Collaborator

Yes, that's what I asked for

@RafaelsRamos
Copy link
Contributor

Got it! Tomorrow I'll try it out, and update the thread, to compare with the approach above 👍

@RafaelsRamos
Copy link
Contributor

Hey @SameenAhnaf 👋 Please let me know what you think. Video sample below.

sample.mp4

@SameenAhnaf
Copy link
Collaborator

I like the new popup menu. But we should use a single filter icon instead of two. Maybe, something like the following image? You may suggest any icon else too.

80840-200

@RafaelsRamos
Copy link
Contributor

Sounds good!

@sineptic
Copy link

hello, maybe you require at least 1 option must be selected? ( because I'd thing that it is bag, when I see empty list of videos)

@RafaelsRamos
Copy link
Contributor

Where's the UX with at least 1 option selection

sample_with_mandatory_selection.mp4

@SameenAhnaf
Copy link
Collaborator

I guess, what sineptic is asking for is that at least one of the stream options among Videos, Shorts and Livestreams should be selected so that no empty feed is shown. Because, any empty feed would feel like a bug.

Maybe, the user should be alert with a toast like "At least one type of stream is required to be selected" while unchecking the only selected stream option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants