Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The back button does not work in LibreTube #5649

Closed
3 tasks done
Pamilg8 opened this issue Feb 24, 2024 · 12 comments · Fixed by #5653
Closed
3 tasks done

The back button does not work in LibreTube #5649

Pamilg8 opened this issue Feb 24, 2024 · 12 comments · Fixed by #5653
Labels
bug Something isn't working can't reproduce

Comments

@Pamilg8
Copy link
Contributor

Pamilg8 commented Feb 24, 2024

Steps to reproduce

  1. Enter LibreTube
  2. Press the back button on your device
  3. Back button doesn't work. It does not work in any section

Expected behavior

The back button should work without problems

Actual behavior

Back button functionality is not working in the app.
This problem happened suddenly

LibreTube version

0.21.1 Debug

Android version

Android 12 vs 13 ( One UI Core 4.1, One UI 5.1)

Other details

XRecorder_24022024_190629.mp4

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Bnyro
Copy link
Member

Bnyro commented Feb 25, 2024

Good catch, it seems like some dependency update now forces us to explicitly enable handling back presses - probably due to the new back gesture invocation APIs added in Android 14.

@Pamilg8
Copy link
Contributor Author

Pamilg8 commented Feb 25, 2024

Good catch, it seems like some dependency update now forces us to explicitly enable handling back presses - probably due to the new back gesture invocation APIs added in Android 14.

I tried the debug version and it didn't fix the problem

@Bnyro
Copy link
Member

Bnyro commented Feb 25, 2024

Strange, it's fixed for me.

@Pamilg8
Copy link
Contributor Author

Pamilg8 commented Feb 25, 2024

Strange, it's fixed for me.

Can you please keep the issue open? Maybe someone helped me😔

@t-e-s-tweb
Copy link

Strange, it's fixed for me.

tried the latest commits but it isn't fixed. It works though by reverting this commit ce8ed66

@Bnyro
Copy link
Member

Bnyro commented Feb 25, 2024

Strange, it's fixed for me.

tried the latest commits but it isn't fixed. It works though by reverting this commit ce8ed66

Reverting this commit only or using a build before that commit (so also reverting any other changes)?

@Bnyro Bnyro reopened this Feb 25, 2024
@t-e-s-tweb
Copy link

Strange, it's fixed for me.

tried the latest commits but it isn't fixed. It works though by reverting this commit ce8ed66

Reverting this commit only or using a build before that commit (so also reverting any other changes)?

only this commit.

i use this command in GitHub workflow

  • name: Revert Commit
    run: |
    git revert -v -n -m 1 ce8ed66 --no-edit -X theirs

@t-e-s-tweb
Copy link

which device are you the testing it on? this and that full screen bug aren't reproducible. I am on MiUi. i wonder what the author of this issue is running as OS.

@Pamilg8
Copy link
Contributor Author

Pamilg8 commented Feb 27, 2024

I test LibreTube on different devices.( Android 12, One UI Core 4.1)
Or Android 13, One UI 5.1
Many Samsung devices have the problem
The back button works when the device is offline

@akano12
Copy link
Collaborator

akano12 commented Mar 3, 2024

Can't reproduce either.
Samsung S20 A13, can you try latest debug?

@Pamilg8
Copy link
Contributor Author

Pamilg8 commented Mar 3, 2024

Can't reproduce either. Samsung S20 A13, can you try latest debug?

I have tried the latest debug on samsung a32 and samsung a21s, a31 and the problem is not fixed. Samsung a13 runs full One UI. You try A21s and a12 running One UI Core version. A32 and a31 are running full One UI 5.1 and One UI 4.1 but they have the same problem. The S20 is an expensive phone. Most users use a budget phone

@Pamilg8
Copy link
Contributor Author

Pamilg8 commented Mar 3, 2024

1709460796.079 10696 21087 21087 I ViewRootImpl@f363c38[Default]: ViewPostIme key 0
1709460796.166 10696 21087 21087 I ViewRootImpl@f363c38[Default]: ViewPostIme key 1
1709460800.235 10696 21087 21087 I ViewRootImpl@f363c38[Default]: MSG_WINDOW_FOCUS_CHANGED 0 1
1709460800.264 10696 21087 21087 D InputTransport: Input channel destroyed: 'ClientS', fd=140

However, when I go back to the home page from the search section, the button works. In other cases, it never works

@libre-tube libre-tube locked and limited conversation to collaborators Mar 7, 2024
@Bnyro Bnyro converted this issue into discussion #5716 Mar 7, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
bug Something isn't working can't reproduce
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants