Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll state reset after rotation change #5808

Closed
3 tasks done
E0697 opened this issue Mar 26, 2024 · 6 comments · Fixed by #5950
Closed
3 tasks done

Scroll state reset after rotation change #5808

E0697 opened this issue Mar 26, 2024 · 6 comments · Fixed by #5950
Labels
bug Something isn't working help wanted Looking for help

Comments

@E0697
Copy link

E0697 commented Mar 26, 2024

Steps to reproduce

  1. Go to subscriptions tab
  2. Start playing a video
  3. Use the swipe up gesture to enter fullscreen mode
  4. Use the swipe down gesture to exit fullscreen mode
  5. Swipe down to go to mini-player
  6. The first swipe down gesture moved the feed position upwards

Expected behavior

The position should be unchanged

Actual behavior

The position is changed as if the swipe down was used in the feed not the fullscreen player

LibreTube version

0.22.1

Android version

Android 14

Other details

The issue was introduced in v0.21, and doesn't seem to affect shorts.

Preview.mp4

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@E0697 E0697 added the bug Something isn't working label Mar 26, 2024
@E0697 E0697 changed the title Swipe Down Exit Gesture Moves Feed Position Exiting Fullscreen Moves Feed to Beginning Mar 27, 2024
@E0697
Copy link
Author

E0697 commented Mar 27, 2024

It turns out that it's not the gesture itself to blame. I used the fullscreen button and it still happens. It moves the feed to the top (latest video). It seems to be intermittent too.

@E0697 E0697 changed the title Exiting Fullscreen Moves Feed to Beginning Exiting Fullscreen Moves Feed Position Mar 31, 2024
@xlash123
Copy link

This bug is only expressed when going into landscape mode. When setting the fullscreen mode to portrait, the bug does not occur.

@xlash123
Copy link

A little more testing shows that any screen rotation transition resets the scroll position in all video feeds. You can replicate this by setting General > Screen Orientation to "Auto-rotation".

I also noticed that not all scrollable lists were affected, such as subscriptions and settings. I could only get it to occur on the video feed lists.

@Bnyro
Copy link
Member

Bnyro commented May 1, 2024

I've tracked it down to be this issue: material-components/material-components-android#3473. Not sure if there's any workaround for this 🤷

@Bnyro
Copy link
Member

Bnyro commented May 1, 2024

The issue applies for the subscriptions, watch history and the views for looking at a channel or a playlist. (SubscriptionsFragment, WatchHistoryFragment, ChannelFragment, PlaylistFragment)

@Bnyro Bnyro added help wanted Looking for help and removed priority: low labels May 1, 2024
@Bnyro Bnyro changed the title Exiting Fullscreen Moves Feed Position Scroll state reset after changing orientation May 1, 2024
@Bnyro Bnyro changed the title Scroll state reset after changing orientation Scroll state reset after rotation change May 1, 2024
@xlash123
Copy link

xlash123 commented May 1, 2024

Correction: by "subscriptions", I meant the view that enumerates your channel subscriptions. The subscriptions video feed is indeed affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Looking for help
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants