Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Android status bar label color #6072

Closed
3 tasks done
Ehab-d opened this issue May 22, 2024 · 3 comments
Closed
3 tasks done

Inconsistent Android status bar label color #6072

Ehab-d opened this issue May 22, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Ehab-d
Copy link

Ehab-d commented May 22, 2024

Steps to reproduce

  1. Switch to the Light/Dark mode in Android
  2. Switch to the Dark/Light mode in LibreTube

Expected behavior

To have the status bar just like it was in 0.22.2:
LibreTube_0 22 2

Actual behavior

This is related to issue #5970 / fix #5978.

The notification bar follows the LibreTube app theme -which is actually fixed-, but the status bar text and labels are black, making them almost unseeable.

LibreTube_0.23.2 – after the fix

LibreTube_0 23 2

LibreTube_0.23.0 – before the fix

LibreTube_0 23 0

LibreTube version

0.23.0 to 0.23.2

Android version

Android 10

Other details

  • The issue did not exist in version 0.22.2.
  • The settings page does not have this issue.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Ehab-d Ehab-d added the bug Something isn't working label May 22, 2024
@Bnyro
Copy link
Member

Bnyro commented May 26, 2024

Can you please test with the latest debug build?

@Ehab-d
Copy link
Author

Ehab-d commented Jun 2, 2024

I have tested almost all the possible cases, and I can confirm that the problem has been solved. 🚀
However, I wanted to point out a behavior you might want to know about...
When exiting full screen mode, the status bar quickly turns light before returning to dark again.

LibreTube 0.23.3 Debug

LibreTube-0.23.2-debug.mp4

And that was not present in LibreTube 0.22.2.

LibreTube 0.22.2

LibreTube-0.22.2.mp4

Of course, this "completely" only happens when Android is in light mode & LibreTube in dark mode.

This may not be a problem.. but I thought you might want to know.

@Bnyro
Copy link
Member

Bnyro commented Jun 3, 2024

When exiting full screen mode, the status bar quickly turns light before returning to dark again.

That's indeed not that nice, but I don't think that we can fix this on the application side. We don't modify that color when you leave fullscreen, we only change the text color of the status bar.

So this certainly looks like an Android bug unfortunately.

@Bnyro Bnyro closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants