Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.24.0 (PLEASE TEST!) #6134

Closed
Bnyro opened this issue Jun 14, 2024 · 19 comments
Closed

Release 0.24.0 (PLEASE TEST!) #6134

Bnyro opened this issue Jun 14, 2024 · 19 comments
Labels
help wanted Looking for help release blocker Needs to be fixed before the next release testers needed Looking for people to test the changes before merging

Comments

@Bnyro
Copy link
Member

Bnyro commented Jun 14, 2024

Beta-Testers searched for upcoming 0.24.0 release

The app is on a feature freeze now until the next release, so it's important to test it to avoid any major bugs and the necessity of hotfix releases.

Please test the app builds from https://github.com/libre-tube/NightlyBuilds and report any regressions here or in a new issue.

Thank you!

Changelog

New features

Bug fixes

@Bnyro Bnyro added testers needed Looking for people to test the changes before merging release blocker Needs to be fixed before the next release help wanted Looking for help labels Jun 14, 2024
@Bnyro Bnyro pinned this issue Jun 14, 2024
@Pamilg8

This comment was marked as resolved.

@gsdgethjfjj
Copy link

Greetings!

Bottom bar is in wrong color when video is opened. For me it's color is correct when you open an app or comments but not the video itself.
1000013924

1000013921

1000013923

@gsdgethjfjj

This comment was marked as resolved.

@ScriptSlayer0
Copy link

Record_2024-06-15-01-37-33.mp4

I have experienced this error with the notification control, it only happens when I clicked on it to enlarge the window, as shown in the video.
Once it is extended it is not possible to stop it in any way.

@mizuhashikuniumi

This comment was marked as duplicate.

@mizuhashikuniumi
Copy link

screen-20240615-140534.mp4

@gloriouspuffy

This comment was marked as off-topic.

@ScriptSlayer0

This comment was marked as off-topic.

@Bnyro

This comment was marked as off-topic.

@ScriptSlayer0

This comment was marked as off-topic.

@tlden

This comment was marked as resolved.

@Pamilg8

This comment was marked as duplicate.

@MatsG23

This comment was marked as resolved.

@MatsG23
Copy link

MatsG23 commented Jun 30, 2024

I am experiencing app crashes playing videos in PiP for some time:

06-30 17:19:02.489  5703  5838 E MediaCodec: client does not own the buffer #2
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer: Video codec error
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:   android.media.MediaCodec$CodecException: client does not own the buffer #2
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:   
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at android.media.MediaCodec.releaseOutputBuffer(Native Method)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at android.media.MediaCodec.releaseOutputBufferInternal(MediaCodec.java:4125)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at android.media.MediaCodec.releaseOutputBuffer(MediaCodec.java:4046)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.mediacodec.AsynchronousMediaCodecAdapter.releaseOutputBuffer(AsynchronousMediaCodecAdapter.java:202)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.skipOutputBuffer(MediaCodecVideoRenderer.java:1528)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.processOutputBuffer(MediaCodecVideoRenderer.java:1330)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.drainOutputBuffer(MediaCodecRenderer.java:2010)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.render(MediaCodecRenderer.java:827)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.render(MediaCodecVideoRenderer.java:940)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.ExoPlayerImplInternal.doSomeWork(ExoPlayerImplInternal.java:1112)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:544)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at android.os.Handler.dispatchMessage(Handler.java:103)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at android.os.Looper.loopOnce(Looper.java:232)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at android.os.Looper.loop(Looper.java:317)
06-30 17:19:02.510  5703  5807 E MediaCodecVideoRenderer:       at android.os.HandlerThread.run(HandlerThread.java:85)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal: Playback error
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:   androidx.media3.exoplayer.ExoPlaybackException: MediaCodecVideoRenderer error, index=0, format=Format(5, null, null, video/avc, avc1.4D401F, 4370178, null, [854, 480, 60.0, ColorInfo(BT709, Limited range, SDR SMPTE 170M, false, 8bit Luma, 8bit Chroma)], [-1, -1]), format_supported=YES
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:623)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at android.os.Handler.dispatchMessage(Handler.java:103)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at android.os.Looper.loopOnce(Looper.java:232)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at android.os.Looper.loop(Looper.java:317)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at android.os.HandlerThread.run(HandlerThread.java:85)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:   Caused by: androidx.media3.exoplayer.video.MediaCodecVideoDecoderException: Decoder failed: c2.exynos.h264.decoder
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.createDecoderException(MediaCodecVideoRenderer.java:1915)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.render(MediaCodecRenderer.java:848)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.render(MediaCodecVideoRenderer.java:940)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.ExoPlayerImplInternal.doSomeWork(ExoPlayerImplInternal.java:1112)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:544)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       ... 4 more
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:   Caused by: android.media.MediaCodec$CodecException: client does not own the buffer #2
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:   
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at android.media.MediaCodec.releaseOutputBuffer(Native Method)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at android.media.MediaCodec.releaseOutputBufferInternal(MediaCodec.java:4125)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at android.media.MediaCodec.releaseOutputBuffer(MediaCodec.java:4046)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.mediacodec.AsynchronousMediaCodecAdapter.releaseOutputBuffer(AsynchronousMediaCodecAdapter.java:202)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.skipOutputBuffer(MediaCodecVideoRenderer.java:1528)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.processOutputBuffer(MediaCodecVideoRenderer.java:1330)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.drainOutputBuffer(MediaCodecRenderer.java:2010)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.render(MediaCodecRenderer.java:827)
06-30 17:19:02.531  5703  5807 E ExoPlayerImplInternal:       ... 7 more
06-30 17:19:02.533  5703  5838 D CCodecBufferChannel: [c2.exynos.h264.decoder#625] MediaCodec discarded an unknown buffer
06-30 17:19:02.533  5703  5838 D CCodecBufferChannel: [c2.exynos.h264.decoder#625] MediaCodec discarded an unknown buffer
06-30 17:19:02.534  5703  5807 D MediaCodec: keep callback message for reclaim
06-30 17:19:02.535  5703  5838 I CCodecConfig: query failed after returning 15 values (BAD_INDEX)
06-30 17:19:02.538  5703  5838 W Codec2Client: query -- param skipped: index = 1073743886.
06-30 17:19:02.538  5703  5838 W Codec2Client: query -- param skipped: index = 1610614798.
06-30 17:19:02.543  5703  5853 D CCodecBuffers: [c2.android.aac.decoder#377:1D-Output.Impl[N]] Client returned a buffer it does not own according to our record: 0
06-30 17:19:02.543  5703  5853 D CCodecBuffers: [c2.android.aac.decoder#377:1D-Output.Impl[N]] Client returned a buffer it does not own according to our record: 1
06-30 17:19:02.543  5703  5853 D CCodecBuffers: [c2.android.aac.decoder#377:1D-Output.Impl[N]] Client returned a buffer it does not own according to our record: 2
06-30 17:19:02.544  5703  5807 D MediaCodec: keep callback message for reclaim
06-30 17:19:02.544  5703  5853 I CCodecConfig: query failed after returning 20 values (BAD_INDEX)
06-30 17:19:02.545  5703  5853 W Codec2Client: query -- param skipped: index = 1342179345.
06-30 17:19:02.545  5703  5853 W Codec2Client: query -- param skipped: index = 2415921170.
06-30 17:19:02.545  5703  5853 W Codec2Client: query -- param skipped: index = 1610614798.
06-30 17:19:02.547  5703  5838 D SurfaceUtils: connecting to surface 0xb400db36372f9010, reason connectToSurface
06-30 17:19:02.547  5703  5838 I MediaCodec: [c2.exynos.h264.decoder] setting surface generation to 5839887
06-30 17:19:02.547  5703  5838 D SurfaceUtils: disconnecting from surface 0xb400db36372f9010, reason connectToSurface(reconnect)
06-30 17:19:02.547  5703  5838 D SurfaceUtils: connecting to surface 0xb400db36372f9000, reason connectToSurface(reconnect-with-listener)
06-30 17:19:02.548  5703  5838 D Codec2-OutputBufferQueue: C2SurfaceSyncMemory created 20(20)
06-30 17:19:02.548  5703  5838 D Codec2-OutputBufferQueue: remote graphic buffer migration 0/0
06-30 17:19:02.548  5703  5838 D Codec2Client: setOutputSurface -- failed to set consumer usage (6/BAD_INDEX)
06-30 17:19:02.548  5703  5838 D Codec2Client: setOutputSurface -- generation=5839887 consumer usage=0x900 sync
06-30 17:19:02.549  5703  5838 D Codec2Client: Surface configure completed
06-30 17:19:02.549  5703  5838 D SurfaceUtils: disconnecting from surface 0xb400db36373d7810, reason disconnectFromSurface
06-30 17:19:02.549  5703  5838 D CCodecBufferChannel: [c2.exynos.h264.decoder#625] MediaCodec discarded an unknown buffer
06-30 17:19:02.550  5703  5838 D CCodecBufferChannel: [c2.exynos.h264.decoder#625] MediaCodec discarded an unknown buffer
06-30 17:19:02.550  5703  5838 D CCodecBufferChannel: [c2.exynos.h264.decoder#625] MediaCodec discarded an unknown buffer
06-30 17:19:02.550  5703  5838 D CCodecBufferChannel: [c2.exynos.h264.decoder#625] MediaCodec discarded an unknown buffer
06-30 17:19:02.552  5703  5853 D CCodecBufferChannel: [c2.android.aac.decoder#377] MediaCodec discarded an unknown buffer
06-30 17:19:02.553  5703  5853 D CCodecBufferChannel: [c2.android.aac.decoder#377] MediaCodec discarded an unknown buffer
06-30 17:19:02.553  5703  5853 D CCodecBufferChannel: [c2.android.aac.decoder#377] MediaCodec discarded an unknown buffer
06-30 17:19:02.553  5703  5853 D CCodecBufferChannel: [c2.android.aac.decoder#377] MediaCodec discarded an unknown buffer
06-30 17:19:02.554  5703  5853 I hw-BpHwBinder: onLastStrongRef automatically unlinking death recipients
06-30 17:19:02.557  5703  5839 I hw-BpHwBinder: onLastStrongRef automatically unlinking death recipients
06-30 17:19:02.558  5703  5838 D SurfaceUtils: disconnecting from surface 0xb400db36372f9010, reason disconnectFromSurface
--------- switch to events
06-30 17:19:02.795  5703  5703 I wm_on_stop_called: [Token=127507263,Component Name=com.github.libretube.Default,Reason=LIFECYCLER_STOP_ACTIVITY,time=16ms]
--------- switch to main
06-30 17:19:03.004  5703  5703 I ExoPlayerImpl: Release 4081f9e [AndroidXMedia3/1.3.1] [bluejay, Pixel 6a, Google, 34] [media3.common, media3.ui, media3.exoplayer, media3.decoder, media3.exoplayer.hls, media3.datasource.cronet, media3.datasource, media3.extractor]
--------- switch to events
06-30 17:19:03.025  5703  5703 I wm_on_destroy_called: [Token=127507263,Component Name=com.github.libretube.Default,Reason=performDestroy,time=108ms]
--------- switch to main
06-30 17:19:03.026  5703  5703 W WindowOnBackDispatcher: sendCancelIfRunning: isInProgress=falsecallback=androidx.activity.OnBackPressedDispatcher$Api34Impl$createOnBackAnimationCallback$1@81ce9e9
06-30 17:19:03.057  5703  5703 E WindowManager: android.view.WindowLeaked: Activity com.github.libretube.ui.activities.MainActivity has leaked window com.android.internal.policy.DecorView{cc5dc43 V.E...... R....... 0,0-598,336 aid=1073741830}[Default] that was originally added here
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.view.ViewRootImpl.<init>(ViewRootImpl.java:1144)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.view.ViewRootImpl.<init>(ViewRootImpl.java:1130)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:427)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:158)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.app.Dialog.show(Dialog.java:352)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at com.github.libretube.ui.fragments.PlayerFragment.openOrCloseFullscreenDialog(PlayerFragment.kt:732)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at com.github.libretube.ui.fragments.PlayerFragment.onPictureInPictureModeChanged(PlayerFragment.kt:1480)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at androidx.fragment.app.Fragment.performPictureInPictureModeChanged(Fragment.java:3238)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at androidx.fragment.app.FragmentManager.dispatchPictureInPictureModeChanged(FragmentManager.java:3296)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at androidx.fragment.app.FragmentManager.lambda$new$3$androidx-fragment-app-FragmentManager(FragmentManager.java:623)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at androidx.fragment.app.FragmentManager$$ExternalSyntheticLambda3.accept(D8$$SyntheticClass:0)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at androidx.activity.ComponentActivity.onPictureInPictureModeChanged(ComponentActivity.java:1097)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.app.Activity.dispatchPictureInPictureModeChanged(Activity.java:9339)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.app.ActivityThread.handleWindowingModeChangeIfNeeded(ActivityThread.java:6581)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.app.ActivityThread.performActivityConfigurationChanged(ActivityThread.java:6368)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.app.ActivityThread.performConfigurationChangedForActivity(ActivityThread.java:6343)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.app.ActivityThread.handleActivityConfigurationChanged(ActivityThread.java:6779)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.app.ActivityThread.handleActivityConfigurationChanged(ActivityThread.java:6713)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.app.servertransaction.ActivityConfigurationChangeItem.execute(ActivityConfigurationChangeItem.java:58)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:60)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.app.servertransaction.TransactionExecutor.executeNonLifecycleItem(TransactionExecutor.java:231)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:152)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:93)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2602)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.os.Handler.dispatchMessage(Handler.java:107)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.os.Looper.loopOnce(Looper.java:232)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.os.Looper.loop(Looper.java:317)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at android.app.ActivityThread.main(ActivityThread.java:8623)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at java.lang.reflect.Method.invoke(Native Method)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
06-30 17:19:03.057  5703  5703 E WindowManager: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:894)

@pokegamer5547

This comment was marked as resolved.

@Bnyro
Copy link
Member Author

Bnyro commented Jul 5, 2024

As said above,

report any regressions here

not issues that already existed in previous releases.

@Bnyro
Copy link
Member Author

Bnyro commented Jul 11, 2024

Thanks for the help everyone, I think we should do in the same way for the next releases 👍

@owosoup
Copy link

owosoup commented Jul 17, 2024

The download support works flawlessly for Seal :) it opens a dialogue to choose whether I want to use a fast download (opens up dialogue on top of Libre tube and closes it after) or just open the app and download from there.

@Bnyro
Copy link
Member Author

Bnyro commented Aug 23, 2024

Fyi, there's no testing phase for the upcoming release due to the fact that it includes the fix for video playback everybody has been waiting for to make LibreTube usable again with public instances, the release after will get a normal testing phase again if everything goes as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Looking for help release blocker Needs to be fixed before the next release testers needed Looking for people to test the changes before merging
Projects
None yet
Development

No branches or pull requests

10 participants