-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate out audio functionality #234
Comments
What do you mean by data? |
I guess I interpreted this as a library rather than an application and it was a bit unexpected that for example the argument to FileConfiguration was the actual string I was just interested in writing a cli to search with. Seems like setting the Still having some issues with shutdown, seems like some OkHttp thread lingers even after calling session.close(). |
You're right, the name is a bit confusing because this is a fully fletched player with library features all merged together. While I like the idea of separating the API part of the project into a different module, I need to combat piracy (low effort piracy) by avoiding to expose crucial parts which can be exploited. That is feasible though. Setting the output to
As I don't use the project as a library specifically I tend to leave those behind, please open a separate issue or PR and I'll sort it out. |
@devgianlu Humm.... I wonder if it performs |
It was indeed closing |
Closing in favor of #245. |
It would be great if audio functionality would be split out into a separate module to enable headless mode where the use is only data rather than playback.
The text was updated successfully, but these errors were encountered: