Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button remapping is totally broken for this core #36

Open
c0d3h4x0r opened this issue Mar 3, 2020 · 3 comments
Open

Button remapping is totally broken for this core #36

c0d3h4x0r opened this issue Mar 3, 2020 · 3 comments

Comments

@c0d3h4x0r
Copy link

Core-specific button remapping works fine with the MAME 2010 core, but it's totally broken in this one, rendering this core largely useless. Totally unable to change the mappings in the RetroArch UI (under Quick Menu >> Controls).

@c0d3h4x0r
Copy link
Author

c0d3h4x0r commented Mar 8, 2020

Finally got to the bottom of this. mame2016-libretro is neglecting to make the following callback to set up all the input descriptors:

environ_cb(RETRO_ENVIRONMENT_SET_INPUT_DESCRIPTORS, desc);

That ID (RETRO_ENVIRONMENT_SET_INPUT_DESCRIPTORS) is present in retromain.c in mame2010-libretro, but it is nowhere to be found in mame2016-libretro.

@c0d3h4x0r
Copy link
Author

I have a working fix; I'll prepare a merge request.

@Lexanadu
Copy link

Bit late to the party but am having this exact issue. Did you get the merge or able to post the fix ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants