SDL 2.28.0+ causes texture misalignment in Mesen2

[TakuikaNinja]

Since SDL 2.28.0, the texture(s) in Mesen2 become misaligned:

Sometimes the texture can be realigned by changing the video settings but it is very inconsistent.
Downgrading SDL to 2.26.5 restores the proper behaviour.
Note: Please use the development builds of Mesen2 for testing.

OS: EndeavourOS (basically Arch)
Display server: X11

[TakuikaNinja]

After a few git bisect attempts, aa53621 was named as the first bad commit. I think the cherry-pick went horribly wrong there, since the original commit (49b5cfa) places the code in X11_HideWindow() but the cherry-picked commit places it in X11_ShowWindow().

[zeta0134]

I can confirm this bug on Arch proper, just updated to sdl2 2.28.1-1 and was greeted with mostly transparent game windows. Mesen2-specific workarounds include resizing the window, but it's temporary and quite glitchy.

[sezero]

CC: @icculus

[icculus]

Ugh, sorry about that! I'll look at that cherry-pick today.

[icculus]

Ok, what the heck, this shouldn't be in HideWindow in the original commit.

I wonder if I made a fix for #4216, then did a git pull --rebase before pushing, and it ended up moving elsewhere?

This is wild, I'm digging further.

[icculus]

This is wild, I'm digging further.

My current thinking is the SDL2 patch is correct (discounting whatever interaction is causing Mesen2 trouble), and I probably did the work in that branch and tested i3 against it, and then either applied a patch to a separate working copy for SDL3, where it landed incorrectly, or just pasted it into the wrong place, which is at least as likely, if not more.

But since our policy is to commit to SDL3 and cherry-pick back to SDL2, that got committed first and then cherry-picked over (and maybe I even thought "weird, it missed the function" and manually fixed it up in SDL2).

Anyhow, the plan now is to run mesen2 under a debugger and reproduce this issue, see what should be done, and fix up the SDL3 commit in any case.

[icculus]

Let's close this and track this over in #8029.