Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all types of unlocking of scripts and not just signing [ROUGH START] #48

Closed
jadwahab opened this issue Sep 22, 2021 · 0 comments · Fixed by #67
Closed

Support all types of unlocking of scripts and not just signing [ROUGH START] #48

jadwahab opened this issue Sep 22, 2021 · 0 comments · Fixed by #67
Labels
enhancement New feature or request

Comments

@jadwahab
Copy link
Member

If we have any types of tx scripts (not just standard ones), txs can be unlocked in many different ways. Previously we only unlocked scripts using signatures which is why we only have the tx.Sign function. This should probably be renamed to tx.Unlock(ctx context, inputIndex uint64, unlocker Unlocker, shf sighashflag).
@jadwahab jadwahab added the enhancement New feature or request label Sep 22, 2021
@tigh-latte tigh-latte linked a pull request Oct 8, 2021 that will close this issue
Enhancement: Tx Unlocker #67
Merged
@mergify mergify bot closed this as completed in #67 Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancement: Tx Unlocker libsv/go-bt
1 participant
@jadwahab