From bad55a6c85ea94eb2da39d6a8af4ed898ff00b98 Mon Sep 17 00:00:00 2001 From: Mark Smith Date: Mon, 26 Jul 2021 09:24:58 +0100 Subject: [PATCH] adding missing varint byte to p2pkh change --- txchange.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/txchange.go b/txchange.go index 5204554b..2ad5e605 100644 --- a/txchange.go +++ b/txchange.go @@ -106,7 +106,8 @@ func (tx *Tx) canAddChange(available uint64, standardFees *Fee) bool { changeOutputFee := uint64(varIntUpper) - changeP2pkhByteLen := 8 + 25 // 8 bytes for satoshi value + 25 bytes for p2pkh script (e.g. 76a914cc...05388ac) + // 8 bytes for satoshi value +1 for varint length + 25 bytes for p2pkh script (e.g. 76a914cc...05388ac) + changeP2pkhByteLen := 8 + 1 + 25 changeOutputFee += uint64(changeP2pkhByteLen * standardFees.MiningFee.Satoshis / standardFees.MiningFee.Bytes) // not enough change to add a whole change output so don't add anything and return