Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building libusb support on Windows and macOS #581

Closed
slouken opened this issue May 26, 2023 · 3 comments · Fixed by #582
Closed

Building libusb support on Windows and macOS #581

slouken opened this issue May 26, 2023 · 3 comments · Fixed by #582
Labels
enhancement New feature or request libusb Related to libusb backend macOS Related to macOS backend Windows Related to Windows backend

Comments

@slouken
Copy link
Contributor

slouken commented May 26, 2023

SDL has a change to allow building hidapi with libusb support on Windows. It was done by abstracting the threading interface, so it can be replaced by other implementations, and the pthread implementation is provided by default.

Please let me know if you'd like this change as a PR!
libsdl-org/SDL@57b33ae
@mcuee mcuee added the libusb Related to libusb backend label May 27, 2023
@mcuee
Copy link
Member

mcuee commented May 27, 2023 •
edited
Loading

Yes please file a PR.

This will also (partially) address the following issue.

@mcuee mcuee added the enhancement New feature or request label May 27, 2023
@mcuee
Copy link
Member

mcuee commented May 27, 2023

@slouken

If possible, you may also want to add macOS support. macOS libusb support is not so useful for real application (requires sudo or some difficult-to-attain entitlement), but it may be useful to troubleshooting purpose and maybe useful for some devices.

@mcuee mcuee added the Windows Related to Windows backend label May 27, 2023
@slouken slouken mentioned this issue May 27, 2023
Merged
@slouken
Copy link
Contributor Author

slouken commented May 27, 2023

The current code works on macOS without any changes. I tested with it a few days ago.

@mcuee mcuee changed the title Building libusb support on Windows Building libusb support on Windows and macOS May 27, 2023
@mcuee mcuee added the macOS Related to macOS backend label May 27, 2023
@Youw Youw closed this as completed in #582 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request libusb Related to libusb backend macOS Related to macOS backend Windows Related to Windows backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libusb: Allow building using non-POSIX runtime slouken/hidapi
2 participants
@mcuee @slouken