Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release proposal: v1.34.1 #2595

Closed
cjihrig opened this issue Jan 4, 2020 · 4 comments
Closed

Release proposal: v1.34.1 #2595

cjihrig opened this issue Jan 4, 2020 · 4 comments

Comments

@cjihrig
Copy link
Contributor

cjihrig commented Jan 4, 2020

New decade, new libuv 🍾

As the v1.x branch currently stands, there are a number of commits queued up, primarily for build/compile issues and better support on Tier 3 platforms. I'd like to release 1.34.1 next week (1/5 - 1/11). Please raise any comments or concerns here.
@bnoordhuis
Copy link
Member

Upgrading libuv in node will close out nodejs/node#31170 now that #2597 has been merged.

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 12, 2020 •
edited
Loading

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1706/
Node.js integration CI: https://ci.nodejs.org/view/libuv/job/libuv-in-node/120/

EDIT:

libuv CI: resume build: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1707/ 💛
Node integration CI failed on a known flake and a V8 profiler test.

@vtjnash
Copy link
Member

vtjnash commented Jan 13, 2020

What's that pipe_server_close failure? Is there an open issue?

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 13, 2020

Not that I'm aware of.

@vtjnash vtjnash mentioned this issue Jan 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bnoordhuis @vtjnash @cjihrig