Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI::_punycode private functions underscored #47

Open
genio opened this issue Jan 7, 2018 · 2 comments
Open

URI::_punycode private functions underscored #47

genio opened this issue Jan 7, 2018 · 2 comments

Comments

@genio
Copy link
Member

genio commented Jan 7, 2018

Make all functions not documented actually private by following the _function_name convention.

While this won't change any behavior or fix any problems, it will follow convention a bit better and reduce some of the exceptions in dist.ini for POD checks.

@genio genio added the modernize label Jan 7, 2018
@karenetheridge
Copy link
Member

karenetheridge commented Mar 27, 2018

Before making this change, we should check with grep.cpan.me that no other distributions are relying on the existing names (and get those fixed first).

It might be a good idea at any rate to add sub aliases with the old names, and a deprecation warning, e.g.:

sub function_name
{
    warnings::warnif('deprecated', 'function_name is intended to be internal only and its use outside this module is not supported');
    goto &_function_name;
}

@jjatria
Copy link

jjatria commented Dec 19, 2018

As part of this month's (and last!) PRC, I started taking a look at this issue. I checked some of the easier methods, and added deprecation warnings to os_path, fix_path, nss, and nid. These are the ones I found no uses for, with the exception of nss, which is used by URI::db.

Not sure if this is worth a pull request, but it does look like a little progress, so I thought I'd point it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants