Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect diffs count in the report table #24

Open
arwer13 opened this issue Oct 24, 2023 · 0 comments
Open

Incorrect diffs count in the report table #24

arwer13 opened this issue Oct 24, 2023 · 0 comments

Comments

@arwer13
Copy link
Contributor

arwer13 commented Oct 24, 2023

The column "Diffs" shows either incorrect or misleading number of differences. E. g. for this run https://app.warp.dev/block/VfjdKiz6Ofrv87pJpFPVHG it is "8" although the difference in html-report is just a single space added.

The config used (config_samples/zksync_mainnet_config_L1.json at the moment):

{
    "contracts": {
        "0xFf7F4d05e3247374e86A3f7231A2Ed1CA63647F2": "OssifiableProxy",
        "0x06185d60eD72a91D1367Eb0733B9d20AE7336D3B": "L1Executor",
        "0x41527B2d03844dB6b0945f25702cB958b6d55989": "OssifiableProxy",
        "0x9a810469F4a451Ebb7ef53672142053b4971587c": "L1ERC20Bridge"
    },
    "explorer_hostname": "api.etherscan.io",
    "github_repo": {
        "url": "https://github.com/txfusion/lido-l2",
        "commit": "fa6a77e694a34dc6f03d57bb8c934941e554ac9d",
        "relative_root": "zksync"
    },
    "dependencies": {
        "@openzeppelin/contracts": {
            "url": "https://github.com/OpenZeppelin/openzeppelin-contracts",
            "commit": "d4fb3a89f9d0a39c7ee6f2601d33ffbf30085322",
            "relative_root": "contracts"
        },
        "@openzeppelin/contracts-upgradeable": {
            "url": "https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable",
            "commit": "f6febd79e2a3a17e26969dd0d450c6ebd64bf459",
            "relative_root": "contracts"
        },
        "@matterlabs/zksync-contracts/l1/contracts": {
            "url": "https://github.com/matter-labs/era-contracts",
            "commit": "3a4506522aaef81485d8abb96f5a6394bd2ba69e",
            "relative_root": "ethereum/contracts"
        }
    }
}
@arwer13 arwer13 mentioned this issue Oct 24, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant