Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Beacon stat values are displayed #163

Closed
skozin opened this issue Nov 22, 2020 · 1 comment · Fixed by #165
Closed

Invalid Beacon stat values are displayed #163

skozin opened this issue Nov 22, 2020 · 1 comment · Fixed by #165
Assignees
@skozin
Labels
bug Something isn't working UI
Milestone
Testnet

Comments

@skozin
Copy link
Member

skozin commented Nov 22, 2020 •
edited
Loading

Branch: lip_3_oracle.

Given this value returned from lido.getBeaconStat():

{
  depositedValidators: 1,
  beaconValidators: 0,
  beaconBalance: 0
}

the following is displayed in the Lido Aragon app UI:

Снимок экрана 2020-11-22 в 15 01 05

Caused by this commit in #153: the units of the returned value have changed from Gwei to validators but the UI was not updated properly and still treats it as Gwei.
@skozin skozin added the UI label Nov 22, 2020
@skozin skozin added this to the Testnet milestone Nov 22, 2020
@skozin skozin self-assigned this Nov 22, 2020
@skozin skozin added the bug Something isn't working label Nov 22, 2020
@skozin skozin mentioned this issue Nov 22, 2020
Merged
@skozin skozin linked a pull request Nov 22, 2020 that will close this issue
Fix beacon stat display in the Lido app UI #165
Merged
@skozin
Copy link
Member Author

skozin commented Nov 22, 2020

Fixed in #165.

@skozin skozin closed this as completed Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skozin skozin

Labels
bug Something isn't working UI
Projects
None yet
Milestone
Testnet
Development

Successfully merging a pull request may close this issue.

Fix beacon stat display in the Lido app UI lidofinance/lido-dao
1 participant
@skozin