Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When tag appears in meta, it adds tag_ as prefix to other meta attributes. #159

Open
jonathanbranam opened this issue Sep 22, 2021 · 0 comments

Comments

@jonathanbranam
Copy link
Contributor

jonathanbranam commented Sep 22, 2021

This occurs with the frequently used meta.lastUpdated field. If this is changed, it will break any code that currently uses the name meta_tag_lastUpated.*.

E.g.

generic_codeable_to_dict({
    'tag': [
        {
                "system": "http://lifeomic.com/fhir/group",
                "code": "group-code-id",
            },        
    ],
    'other': 'ok',
})
>>> 
{'tag_other': 'ok',
 'tag_system__lifeomic.com/fhir/group__code': 'group-code-id'}

Code references:

if "tag" in codeable_dict:
return (
[without_keys(codeable_dict, ["tag"]), *codeable_dict["tag"]],
join_underscore([prefix, "tag"]),
)

"tag_lastUpdated": "2019-08-13T17:47:18.957Z",

HL7 FHIR Resources docs. See Meta.lastUpdated and Meta.tag:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant