Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidenav plugin cannot be destroyed and recreated #116

Closed
jbalsas opened this issue Jan 20, 2016 · 1 comment
Closed

Sidenav plugin cannot be destroyed and recreated #116

jbalsas opened this issue Jan 20, 2016 · 1 comment
Assignees
@pat270

Comments

@jbalsas
Copy link
Contributor

jbalsas commented Jan 20, 2016

The Sidenav plugin does not have an API to destroy instances. This is particularly harmful in SPA environments, where the plugin needs to be destroyed upon navigation and instantiated again.

In particular, https://github.com/liferay/lexicon/blob/master/src/js/side-navigation.js#L676 makes new instantiations fail because the reference to the toggler to be destroyed is kept in the document.
@pat270 pat270 self-assigned this Jan 22, 2016
@pat270 pat270 mentioned this issue Jan 27, 2016
Closed
@pat270
Copy link
Member

pat270 commented Jan 29, 2016

Fixed at c800d4c

@pat270 pat270 closed this as completed Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pat270 pat270

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pat270 @jbalsas