Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BS4 compat layer - Buttons mixing of btn-default and btn-primary #340

Closed
marcoscv-work opened this issue Jun 30, 2017 · 6 comments
Closed
Labels
comp: clay-css Issues related to Clay CSS

Comments

@marcoscv-work
Copy link
Member

When you combine buttons they can be shown wrong, this pattern happen a lot in liferay-portal.

btn-default & btn-primary + hover state:
image

@marcoscv-work
Copy link
Member Author

#341

@yuchi
Copy link

yuchi commented Jun 30, 2017

IMHO this is the portal not respecting the BS contract. Should be fixed there, non on Clay.

@jbalsas
Copy link
Contributor

jbalsas commented Jun 30, 2017

Hey @yuchi, glad to see you around! 😉

We are implementing a bs3-bs4 compat layer for liferay portal to ease up our own migration process. We plan to cover all these small changes and fix the portal side until we can get rid of everything.

@yuchi
Copy link

yuchi commented Jun 30, 2017

Hi @jbalsas, yeah sorry for not being so present anymore…

Is 7.0 going to migrate to BS4 then? I think it’s a little bit risky…

@jbalsas
Copy link
Contributor

jbalsas commented Jun 30, 2017

We're in a bit of a crosshairs here, but yes, the idea is to migrate to BS4.

@matuzalemsteles matuzalemsteles added the comp: clay-css Issues related to Clay CSS label Nov 23, 2018
@pat270
Copy link
Member

pat270 commented Nov 28, 2018

This is an issue in Portal.

@pat270 pat270 closed this as completed Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: clay-css Issues related to Clay CSS
Projects
None yet
Development

No branches or pull requests

5 participants