Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2-beta: Remove Font Awesome #342

Closed
pat270 opened this issue Jul 11, 2017 · 10 comments
Closed

v2-beta: Remove Font Awesome #342

pat270 opened this issue Jul 11, 2017 · 10 comments
Milestone

Comments

@pat270
Copy link
Member

pat270 commented Jul 11, 2017

Bootstrap 4 dropped all icon fonts, left up to 3rd party devs to include whatever icon font they want.

@pat270 pat270 added this to the 2.0.0-beta milestone Jul 11, 2017
@jbalsas
Copy link
Contributor

jbalsas commented Jul 27, 2017

Makes sense. UX has specifically asked that only designed svg icons are shipped by default, so we are also going in this direction.

We just need to make sure we have a clear path for developers to add icon fonts and use them independently of what we ship in clay.

@yuchi
Copy link

yuchi commented Aug 29, 2017

If themes could depend on bundles then we could have FA3 and FA4 resource providers.

@jbalsas Can the new loader help on this? Are static packages’ resources available?

@jbalsas
Copy link
Contributor

jbalsas commented Aug 29, 2017

Yeah, I think all resources are available when bundled using the new method. In any case, it sounds like these could go as ThemeContributors, for example.

@jbalsas
Copy link
Contributor

jbalsas commented Aug 29, 2017

Just for clarification, we want to stop bundling the icon fonts in Clay, but we'll still figure out a way to provide them in Liferay Portal ootb.

@yuchi
Copy link

yuchi commented Aug 29, 2017

[…] these could go as ThemeContributors […]

Well, usually I think it’s a theme’s responsibility to bring the icon packs to the page but actually it’s more an editorial requiriment.

So from one side apps and themes should be able to “ask” for an icon pack, but also editors need to access them. Totally Out Of Topic™ but having a DDM field type “Icon” where you can choose one from the available icon packs would be totally awesome.

@jbalsas
Copy link
Contributor

jbalsas commented Aug 29, 2017

ThemeContributors (albeit their bad name) add resources globally independently of the applied Theme. That's why it might be a good option to make them easily available. They double as themelets, so a themelet including FA4 could make it be always available if deployed as a ThemeContributor.

Out of Topic™, where and how would you use the Icon field? Is this something that should be needed inside the WYSWYG editors as well?

@yuchi
Copy link

yuchi commented Aug 29, 2017

Out of Topic™, for example if you are writing a list of features of a product (see this example from smc.it). Sometimes you have them as rasterized images, sometimes as SVG, sometimes as icons in the icon packs have in the page (typically font-awesome). Another very good case are Call to Actions and buttons (see later in that same page), where icons must be either icon fonts or vectorial.

@yuchi
Copy link

yuchi commented Aug 29, 2017

The perfect solution would be an icon chooser, configurable to accept (or not) files from the DM and/or icon fonts and/or SVG icons.

@yuchi
Copy link

yuchi commented Aug 29, 2017

Other examples where such a selector would have benefitted: click on a slice here (it’s a Web Content structure/tmpl), or look at «Servizi Online» in this page, or as AssetCategoryProperty values here.

@jbalsas
Copy link
Contributor

jbalsas commented Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants