Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticker #354

Closed
carloslancha opened this issue Jul 27, 2017 · 3 comments
Closed

Sticker #354

carloslancha opened this issue Jul 27, 2017 · 3 comments

Comments

@carloslancha
Copy link
Contributor

carloslancha commented Jul 27, 2017

Hi!

I'm implementing the sticker component in metal-clay but I'm having some issues with the styling. I've done following http://liferay.github.io/clay/content/badges-and-labels/ markup, but there're classes that doesn't exist like sticker-circle, sticker-default, sticker-static, etc.

Are those classes missing or do I have to use other markup?

Also I noticed that the previous .sticker had an absolute positioning by default (overwritten by .sticker-static if necessary). It would be very helpful having examples of the correct current markup.

Thx!

@robframpton
Copy link

Hey @carloslancha

The http://liferay.github.io/clay site isn't ever going to be updated with Clay 2.0 markup/examples, it's simply there for legacy purposes.

The new electric based clay site is in the works at https://github.com/Robert-Frampton/claycss.com/tree/2.0.

@pat270 , can you share the google doc you have with Carlos that details which components are finished in Clay 2.0? The components that are listed as finished in this doc are the only ones that also have updated docs in the electric site.

@pat270
Copy link
Member

pat270 commented Jul 27, 2017

Hey Carlos,

A few things have changed, .sticker-default is .sticker-secondary now. We've also added .sticker-light and .sticker-dark to keep it inline with Bootstrap 4's variant colors. Stickers can be positioned absolute by using the positional classes .sticker-top-left, .sticker-top-right, .sticker-bottom-right, and .sticker-bottom-left. The borders can be modified using the Bootstrap 4 border utility classes .rounded-0, .rounded, .rounded-circle.

You can also run the old docs site using the develop branch and it should have updated markup as well. We're still in alpha and so is Bootstrap 4 so mark up will probably change even if it's "done".

@carloslancha
Copy link
Contributor Author

Great guys, Thx!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants