Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize clay-css and clay npm packages #837

Closed
jbalsas opened this issue Apr 24, 2018 · 6 comments
Closed

Reorganize clay-css and clay npm packages #837

jbalsas opened this issue Apr 24, 2018 · 6 comments
Labels
type: enhancement Issues that are open to bring improvements or refinement of code
Milestone

Comments

@jbalsas
Copy link
Contributor

jbalsas commented Apr 24, 2018

In order to fully leverage cdns like https://unpkg.com/ or https://www.jsdelivr.com/, we need to have a nice npm package published.

There's still some confusion with the current clay package, as it pretty much brings only css.

For these reasons, I'm proposing:

  • Rename clay to clay-css
  • Create a clay package that exposes the compiled css and js bundling all components and resources

Unless someone heavily disagrees, I'll send a PR with these changes later ;)

/cc @matuzalemsteles, @julien, @carloslancha, @pat270

Fair warning, @bryceosterhaus, @mthadley, as this might affect you... what are you currently using and how?

@julien
Copy link
Contributor

julien commented Apr 24, 2018

@jbalsas I'm totally OK with that proposition.

@mthadley
Copy link

We are bundling the CSS from the current clay package. More specifically, we are depending on the includePaths export from the package, and passing that to sass-loader.

So for us, this would be a breaking change, and we would need to instead depend on this new clay-css package. Thankfully, this seems like it wouldn't be much trouble for us to fix.

@jbalsas
Copy link
Contributor Author

jbalsas commented Apr 24, 2018

Would it might make sense for this clay distributable package to include sources... specially scss and ES+ which could be rebundled from the different individual packages, or is it better to assume the breaking change?

After all, you won't be needing the rest of things in there...

@mthadley
Copy link

I don't think the breaking change is a big deal for us. Also, it should lead to a more cleanly organized set of packages, right?

@jbalsas
Copy link
Contributor Author

jbalsas commented Apr 24, 2018

That's what I think, yeah... we would have:

  • clay -> For distribution purposes only and usage through cdn
  • clay-css -> CSS framework and implementation
  • clay-* -> UI components (js + soy + webcomponents)

Does that make sense? Is there any other way this would be more easily understandable?

@jbalsas jbalsas added this to the 2.0.0 milestone Apr 25, 2018
@jbalsas jbalsas added the type: enhancement Issues that are open to bring improvements or refinement of code label Apr 25, 2018
@jbalsas
Copy link
Contributor Author

jbalsas commented Apr 25, 2018

This has been done and published as rc.12 to verify. @mthadley, can you guys check if switching to clay-css keeps working the same way for you?

Thanks!

@jbalsas jbalsas closed this as completed Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Issues that are open to bring improvements or refinement of code
Projects
None yet
Development

No branches or pull requests

3 participants