Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle undefined current wallet #87

Merged
merged 11 commits into from
May 11, 2023
Merged

Conversation

Addminus
Copy link
Contributor

@Addminus Addminus commented May 3, 2023

No description provided.

@chybisov
Copy link
Member

chybisov commented May 4, 2023

Should we also change the provider here to account.signer?.provider or maybe even remove one and use account.signer?.provider where needed?

provider: currentWallet?.account?.provider,

}
throw Error('No signer object after chain switch');
},
// switchChain: async (reqChainId: number) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll comment that back in for merging

Copy link
Contributor Author

@Addminus Addminus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i checked it with metamask, walletconnect and taho. seems to work

@chybisov chybisov merged commit 5b37b6f into main May 11, 2023
@chybisov chybisov deleted the LF-wallet-management-fix branch May 11, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants