Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: wrong macOS wheel tags #376

Closed
hombit opened this issue Jun 4, 2024 · 0 comments · Fixed by #378
Closed

CI: wrong macOS wheel tags #376

hombit opened this issue Jun 4, 2024 · 0 comments · Fixed by #378

Comments

@hombit
Copy link
Member

hombit commented Jun 4, 2024 •
edited
Loading

Recent cibuildwheel updated delocate which revealed that we (always?) used to set wrong platform tag. The reason is in linking vs dynamic libraries installed from brew, which are always targeted to the current macOS version. The least we should do is setting the correct platform tags.
@hombit hombit changed the title CI: rebuild brew dependencies CI: wrong macOS wheel tags Jun 5, 2024
@hombit hombit mentioned this issue Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set the correct platform tag for macOS wheels light-curve/light-curve-python
1 participant
@hombit