Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bolometric.py #430

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Update bolometric.py #430

merged 4 commits into from
Oct 1, 2024

Conversation

erusseil
Copy link
Contributor

@erusseil erusseil commented Oct 1, 2024

Replace negative flux values by 0. Provides much better fits, since the temperature is not used for bolometric purposes.

erusseil and others added 2 commits October 1, 2024 15:28
@erusseil erusseil marked this pull request as ready for review October 1, 2024 13:42
@hombit hombit enabled auto-merge October 1, 2024 13:56
@hombit hombit disabled auto-merge October 1, 2024 13:58
@hombit hombit enabled auto-merge (squash) October 1, 2024 13:58
Copy link

codspeed-hq bot commented Oct 1, 2024

CodSpeed Performance Report

Merging #430 will not alter performance

Comparing erusseil:master (308b063) with master (f2d0566)

Summary

✅ 99 untouched benchmarks

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.44%. Comparing base (f2d0566) to head (308b063).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   82.44%   82.44%           
=======================================
  Files           9        9           
  Lines        2564     2564           
=======================================
  Hits         2114     2114           
  Misses        450      450           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hombit hombit merged commit e60a14d into light-curve:master Oct 1, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants