Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check internal references #326

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Check internal references #326

merged 2 commits into from
Jun 27, 2019

Conversation

raboof
Copy link
Contributor

@raboof raboof commented Jun 26, 2019

Fixes #120

raboof added a commit to akka/akka that referenced this pull request Jun 26, 2019
@raboof
Fix paradox anchor references
8e69e82 
Found by lightbend/paradox#326
@raboof raboof mentioned this pull request Jun 26, 2019
Merged
@raboof
Copy link
Contributor Author

raboof commented Jun 26, 2019

Tested with Akka, found some invalid links, no false positives.

pvlugter
pvlugter approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Awesome. Just fixed some broken or outdated anchor references in the Cinnamon docs using this.

ennru
ennru approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! LGTM.

@2m 2m added this to the 0.5.6 milestone Jun 27, 2019
@2m 2m merged commit a156fb3 into master Jun 27, 2019
raboof added a commit to akka/akka that referenced this pull request Jun 27, 2019
@raboof
Fix paradox anchor references (#27226)
d758e74 
* Fix paradox anchor references

Found by lightbend/paradox#326

* Remove duplicate anchors in paradox docs

Found by lightbend/paradox#328
@ennru ennru deleted the checkInternalReferences branch May 6, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

@pvlugter pvlugter pvlugter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Check anchor targets in @ref directive
4 participants
@raboof @pvlugter @ennru @2m