Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for duplicate anchors #329

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Check for duplicate anchors #329

merged 1 commit into from
Jun 27, 2019

Conversation

raboof
Copy link
Contributor

@raboof raboof commented Jun 27, 2019

Part of #53. Resolves #319.
Tested with akka/akka#27226, needed to remove some 'manual' anchors but no further false positives

Copy link
Contributor

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice one!

@raboof raboof mentioned this pull request Jun 27, 2019
Copy link
Member

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM2. And resolves #319.

@pvlugter pvlugter merged commit 2b8ec0a into master Jun 27, 2019
@pvlugter pvlugter added this to the 0.5.6 milestone Jun 27, 2019
@jrudolph
Copy link
Contributor

jrudolph commented Aug 7, 2019

Can we make these warnings and also not stop processing after the first occurrence?

@ennru ennru deleted the checkoutDuplicateAnchors2 branch May 6, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add check for dups in TOC
4 participants