Ensure paradoxBrowse works on Linux #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation on exactly which platforms the AWT Desktop API works on is scarce, I read it's supposed to work on Gnome (and nothing else on Linux), but I'm using Gnome, and it doesn't work. This change falls back to using `xdg-open` if the `XDG_CURRENT_DESKTOP` environment variable is set, this should work on any desktop environment that supports the [XDG standard](https://www.freedesktop.org/wiki/Software/xdg-utils/), this includes Gnome, KDE, Unity, Xfce etc etc, so has much better support than the AWT Desktop API. Also, this change also checks if the AWT Desktop API supports the AWT browse command. Apparently on some Linux platforms, the Desktop API is supported but browse isn't.
ennru
approved these changes
Sep 9, 2019
raboof
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation on exactly which platforms the AWT Desktop API works on is scarce, I read it's supposed to work on Gnome (and nothing else on Linux), but I'm using Gnome, and it doesn't work. This change falls back to using
xdg-openif theXDG_CURRENT_DESKTOPenvironment variable is set, this should work on any desktop environment that supports the XDG standard, this includes Gnome, KDE, Unity, Xfce etc etc, so has much better support than the AWT Desktop API.Also, this change also checks if the AWT Desktop API supports the AWT browse command. Apparently on some Linux platforms, the Desktop API is supported but browse isn't.