Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow matching parenthese pairs to occur inside of directive sou… #386

Merged

Conversation

jrudolph
Copy link
Contributor

This is especially useful inside of @javadoc directives that go to JDK 10
style method anchors which can contain parentheses in the anchor.

It's an alternative to #368 that actually allows nested parentheses.

This is especially useful inside of `@javadoc` directives that go to JDK 10
style method anchors which can contain parentheses in the anchor.
Copy link
Contributor

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you for fixing this.

@ennru ennru changed the title Allow matching parenthese pairs to occur inside of directive sources Allow matching parenthese pairs to occur inside of directive sou… Nov 20, 2019
@ennru ennru merged commit 7a4a7f8 into lightbend:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants