Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose property for relative source path #540

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Conversation

justinp
Copy link
Contributor

@justinp justinp commented Sep 30, 2022

I'm using paradox from a Bitbucket repository and I'd like to make source links the way they exist for GitHub. Rather than making a specific property, I decided to try to piece the URL together from parts. The only part that I can't find a way to access is the relative path from the root of the repository to the markdown source file.

This change adds relative to Page so that, for example $page.self.relative$ can be used.

@lightbend-cla-validator
Copy link
Collaborator

@lightbend-cla-validator
Copy link
Collaborator

Hi @justinp,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

Copy link
Member

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Thanks.

@pvlugter
Copy link
Member

Looks like the CLA check is failing, as the CLA has been updated.

@justinp
Copy link
Contributor Author

justinp commented Oct 18, 2022

Thanks.

I noticed the CLA thing, but I submitted it right after I opened this PR and again just now, and it still seems to appear stuck.

@pvlugter pvlugter closed this Oct 18, 2022
@pvlugter pvlugter reopened this Oct 18, 2022
@pvlugter
Copy link
Member

Re-triggered the CLA check with reopening the PR. All good. Thanks.

@pvlugter pvlugter merged commit 289dbde into lightbend:master Oct 18, 2022
@justinp
Copy link
Contributor Author

justinp commented Oct 20, 2022

Thanks for merging it!

What's the process I need to go through to get an officially published artifact I can use?

@pvlugter
Copy link
Member

Released paradox 0.10.3 with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants