From 1bcd1576cd42384761d06c2fd9f1c599c4c3c642 Mon Sep 17 00:00:00 2001 From: Andrea Raspitzu Date: Wed, 5 Feb 2020 11:18:10 +0100 Subject: [PATCH 1/4] Add advisory section for wumbo channels: We advise the implementors to provide the means to increase the number confirmations needed to confirm large channels --- 02-peer-protocol.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/02-peer-protocol.md b/02-peer-protocol.md index 66d539e5e..f8f7d71c7 100644 --- a/02-peer-protocol.md +++ b/02-peer-protocol.md @@ -192,6 +192,10 @@ know this node will accept `funding_satoshis` greater than or equal to 2^24. Since it's broadcast in the `node_announcement` message other nodes can use it to identify peers willing to accept large channel even before exchanging the `init` message with them. +Implementors are advised to provide the means to scale the number of confirmations, tweaking +`accept_channel.minimum_depth`, with the size of the funding amount. A rule of thumb is to +wait enough blocks until the cumulative block reward exceeds the size of the channel. + #### Requirements The sending node: From c79b82a5de4b920d4050e5b7e04fb7d871d6ce57 Mon Sep 17 00:00:00 2001 From: Andrea Raspitzu Date: Tue, 18 Feb 2020 18:26:54 +0100 Subject: [PATCH 2/4] Replace Implementors with Implementers to please the spellchecker --- 02-peer-protocol.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/02-peer-protocol.md b/02-peer-protocol.md index f8f7d71c7..a4282030f 100644 --- a/02-peer-protocol.md +++ b/02-peer-protocol.md @@ -192,7 +192,7 @@ know this node will accept `funding_satoshis` greater than or equal to 2^24. Since it's broadcast in the `node_announcement` message other nodes can use it to identify peers willing to accept large channel even before exchanging the `init` message with them. -Implementors are advised to provide the means to scale the number of confirmations, tweaking +Implementers are advised to provide the means to scale the number of confirmations, tweaking `accept_channel.minimum_depth`, with the size of the funding amount. A rule of thumb is to wait enough blocks until the cumulative block reward exceeds the size of the channel. From 2cfe2c6c985d96976f2f15912deb76a7285d0be4 Mon Sep 17 00:00:00 2001 From: Andrea Raspitzu Date: Tue, 3 Mar 2020 09:34:03 +0100 Subject: [PATCH 3/4] Advise for the block reward to largely exceed the funding amount --- 02-peer-protocol.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/02-peer-protocol.md b/02-peer-protocol.md index a4282030f..ee941f705 100644 --- a/02-peer-protocol.md +++ b/02-peer-protocol.md @@ -194,7 +194,7 @@ willing to accept large channel even before exchanging the `init` message with t Implementers are advised to provide the means to scale the number of confirmations, tweaking `accept_channel.minimum_depth`, with the size of the funding amount. A rule of thumb is to -wait enough blocks until the cumulative block reward exceeds the size of the channel. +wait enough blocks until the cumulative block reward largely exceeds the size of the channel. #### Requirements From 6cc31bba3975d5d3ef3d8668c2f74235241c6a23 Mon Sep 17 00:00:00 2001 From: Andrea Raspitzu Date: Wed, 18 Mar 2020 15:36:02 +0100 Subject: [PATCH 4/4] Address PR feedback --- 02-peer-protocol.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/02-peer-protocol.md b/02-peer-protocol.md index ee941f705..5223d646a 100644 --- a/02-peer-protocol.md +++ b/02-peer-protocol.md @@ -193,8 +193,7 @@ Since it's broadcast in the `node_announcement` message other nodes can use it t willing to accept large channel even before exchanging the `init` message with them. Implementers are advised to provide the means to scale the number of confirmations, tweaking -`accept_channel.minimum_depth`, with the size of the funding amount. A rule of thumb is to -wait enough blocks until the cumulative block reward largely exceeds the size of the channel. +`accept_channel.minimum_depth` and `accept_channel.to_self_delay`, with the size of the funding amount. #### Requirements