Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs in repo with HTTP 404 error response 2024-03-27 edition #628

Open
dstadulis opened this issue Mar 27, 2024 · 3 comments
Open

URLs in repo with HTTP 404 error response 2024-03-27 edition #628

dstadulis opened this issue Mar 27, 2024 · 3 comments

Comments

@dstadulis
Copy link

dstadulis commented Mar 27, 2024

* [lngraph](https://github.com/xsb/lngraph) - Personal Lightning Network explorer using Neo4j Browser

Messages are typically sent with the record ID `34349334`. You can find a registry for such records [here](https://github.com/satoshisstream/satoshis.stream/blob/main/TLV\_registry.md). You may also submit your own suggestions.

The actual message is sent with record `34349334`. Depending on the purpose of the message, [other records](https://github.com/satoshisstream/satoshis.stream/blob/main/TLV\_registry.md) may be used.

[Bitcoin UTXO](https://mirror.xyz/0xaFaBa30769374EA0F971300dE79c62Bf94B464d5/Yetu-6pZkbQCOpsBxswn\_7dGUZDxoBU8NrOQIZScwpg)

BIP](https://github.com/jonasnick/bips/blob/musig2/bip-musig2.mediawiki)

draft](https://github.com/jonasnick/bips/blob/musig2/bip-musig2.mediawiki)

[See how the client interceptor is coded in Aperture](https://github.com/lightninglabs/aperture/blob/master/lsat/client\_interceptor.go)

[https://github.com/lightninglabs/lndclient/blob/master/lightning\_client.go#L256](https://github.com/lightninglabs/lndclient/blob/master/lightning\_client.go#L256)

{% embed url="https://github.com/lightninglabs/lndclient/blob/master/lightning_client.go#L230" %}

[https://github.com/lightninglabs/lndclient/blob/master/router\_client.go#L58](https://github.com/lightninglabs/lndclient/blob/master/router\_client.go#L58)

`v0.23.5`](https://github.com/btcsuite/btcd/releases/tag/v0.23.5) MUST be used.

[Must read: Code contribution guidelines](https://github.com/lightningnetwork/lnd/blob/master/docs/code\_contribution\_guidelines.md)

This tutorial will leverage the Polar application for setting up a local cluster of Lightning Network nodes on regtest. Polar [can be downloaded](https://github.com/lightninglabs/docs.lightning.engineering/tree/9423e81a91e5a382442d5fa2fdacde019133dbcb/build-a-lapp/lightningpolar.com) for MacOS, Linux, and Windows. The source code is hosted [on Github](https://github.com/jamaljsr/polar/releases/).

[README](https://github.com/lightningnetwork/lnd/tree/master/lntemp) for more

Javascript](https://developers.google.com/protocol-buffers/docs/reference/javascript-generated).

@Liongrass
Copy link
Contributor

I checked all these links, and almost all of them are not 404s. I think the issue is how the script picks up the pre-formatted URLs in the raw code (e.g. https://github.com/lightningnetwork/lnd/blob/master/docs/code\_contribution\_guidelines.md), which on the final page show up as https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md and are reachable. Some other links are not displayed on the Builder's Guide.

I found two links that led nowhere, one I updated, the other I removed.

Thank you for the report, I believe the issue can be closed now.

@dstadulis
Copy link
Author

almost all of them are not 404s

I just spot checked the bottom 5 and 4 were 404s

one I updated, the other I removed.

Where can I view these changes?

@Liongrass
Copy link
Contributor

Liongrass commented Mar 28, 2024

If you copy the URLs from the issue above they may appear to be 404s, but if you click on the links in the Builder's Guides they are not 404s. I don't know why this shows up above for example https://github.com/lightninglabs/docs.lightning.engineering/tree/9423e81a91e5a382442d5fa2fdacde019133dbcb/build-a-lapp/lightningpolar.com but in the Builder's Guide it's a functional link to https://lightningpolar.com/.

The last two are not documents from the Builder's Guide, they are documents copied over from the code base, where I assume they live as historical records (especially the 0.16.0 release notes).

The two changes I made yesterday are included in this commit. (Edit, the commit only shows one link from above being removed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants