Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalise multiverse method names to support all proofs. #523

Closed
dstadulis opened this issue Sep 21, 2023 · 0 comments · Fixed by #518
Closed

Generalise multiverse method names to support all proofs. #523

dstadulis opened this issue Sep 21, 2023 · 0 comments · Fixed by #518
Assignees
@ffranr

Comments

@dstadulis
Copy link
Collaborator

dstadulis commented Sep 21, 2023 •
edited by ffranr
Loading

Now that we can insert/query issuance and transfer proofs via the QueryProof and InsertProof RPC endpoints, we should update variable and function naming within our code to reflect that fact. The code is currently named towards handling issuance proofs only.

This #496 fixes this to some degree. I will also start a further PRs to handle the remaining cases.
@dstadulis dstadulis moved this from 🆕 New to 👀 In review in Taproot-Assets Project Board Sep 21, 2023
@dstadulis dstadulis linked a pull request Sep 21, 2023 that will close this issue
bug hunting: attempt to lock coins for Tap addr until 10min time out #515
Closed
@ffranr ffranr changed the title [tracking]: Conclude clean up PRs from Sprint 6 Generalise multiverse method names to support all proofs. Sep 21, 2023
@ffranr ffranr mentioned this issue Sep 21, 2023
Merged
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ffranr ffranr

Labels
None yet
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
No milestone
2 participants
@ffranr @dstadulis