Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the universe proof courier by default for all itests. #649

Closed
ffranr opened this issue Nov 3, 2023 · 1 comment · Fixed by #712
Closed

Enable the universe proof courier by default for all itests. #649

ffranr opened this issue Nov 3, 2023 · 1 comment · Fixed by #712
Assignees
Labels
enhancement New feature or request itests
Milestone

Comments

@ffranr
Copy link
Contributor

ffranr commented Nov 3, 2023

The universe RPC proof courier should be enabled by default for all integration tests. We should also retain the ability to specify the use of the hashmail proof courier for certain itests.

Completing this work should allow use to simplify our code by getting rid of checks such as:

if c.cfg.ProofCourierCfg == nil {

And allow us to remove this helper function which we currently use to sidestep the proof transfer send step:

func sendProof(t *harnessTest, src, dst *tapdHarness, scriptKey []byte,

This helper function was created before we had a reliable proof courier.

@ffranr ffranr added enhancement New feature or request itests labels Nov 3, 2023
@ffranr
Copy link
Contributor Author

ffranr commented Nov 6, 2023

There are 28 sendProof call sites.

@Roasbeef Roasbeef added this to the v0.4 milestone Nov 28, 2023
@Roasbeef Roasbeef moved this from 🆕 New to 🔖 Ready in Taproot-Assets Project Board Nov 28, 2023
@guggero guggero moved this from 🔖 Ready to 🏗 In progress in Taproot-Assets Project Board Nov 29, 2023
@guggero guggero moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Dec 1, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request itests
Projects
Status: ✅ Done
3 participants