Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: generate git release tags via a new make command #729

Closed
ffranr opened this issue Dec 7, 2023 · 1 comment · Fixed by #720
Closed

[feature]: generate git release tags via a new make command #729

ffranr opened this issue Dec 7, 2023 · 1 comment · Fixed by #720
Assignees
Labels
enhancement New feature or request version Issues which relate to data structure versioning

Comments

@ffranr
Copy link
Contributor

ffranr commented Dec 7, 2023

In this issue we add a new Makefile command release-tag which will create a new git release tag.

The command uses the version string found in version.go to ensure consistency. It will also ensure that the new version string is SemVer compliant.

During the execution of the GitHub release workflow the git tag should be compared to the version string produced by the release-tag make command to ensure consistency.

We should implement this work in a sufficiently general way so that we can use it in our other repositories/projects.

This work will require minimal documentation in relation to version strings. So we should close #715 in favour of this issue.

@ffranr ffranr added enhancement New feature or request version Issues which relate to data structure versioning labels Dec 7, 2023
@ffranr ffranr self-assigned this Dec 7, 2023
@ffranr ffranr moved this from 🆕 New to 🏗 In progress in Taproot-Assets Project Board Dec 7, 2023
@ffranr ffranr linked a pull request Dec 7, 2023 that will close this issue
@ffranr
Copy link
Contributor Author

ffranr commented Dec 7, 2023

// These constants define the application version and follow the semantic
// versioning 2.0.0 spec (http://semver.org/).
const (
	// AppMajor defines the major version of this binary.
	AppMajor uint = 0

	// AppMinor defines the minor version of this binary.
	AppMinor uint = 17

	// AppPatch defines the application patch for this binary.
	AppPatch uint = 0

	AppStatus = "beta"

	// AppPreRelease MUST only contain characters from
	// the semantic versioning spec.

        // AppPreRelease MUST only contain characters from
	// the semantic versioning spec.
	AppPreRelease = "rc1"

	GitTagIncludeStatus = true

@ffranr ffranr moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Dec 21, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request version Issues which relate to data structure versioning
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant