Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListPayments should offer pagination #3753

Closed
alexbosworth opened this issue Nov 21, 2019 · 2 comments
Closed

ListPayments should offer pagination #3753

alexbosworth opened this issue Nov 21, 2019 · 2 comments
Labels
enhancement Improvements to existing features / behaviour feature request Requests for new features payments Related to invoices/payments rpc Related to the RPC interface
Milestone

Comments

@alexbosworth
Copy link
Contributor

When fetching invoices and other records like forwards via the RPC, those record sets are separated into pages to allow for scalable retrieval of data.

With ListPayments all of the payments are returned in a single response. If a node is doing regular payments or the incomplete payments flag is used, the number of results from this request can be very large.

In PR #1962 it was suggested that the fix should be to add pagination.

@wpaulino wpaulino added enhancement Improvements to existing features / behaviour feature request Requests for new features payments Related to invoices/payments rpc Related to the RPC interface labels Nov 22, 2019
@bitromortac
Copy link
Collaborator

bitromortac commented Dec 15, 2019

I will try to do this 👍

Update: still working on it, almost finished

@Roasbeef
Copy link
Member

Roasbeef commented Apr 8, 2020

Closed by #3960. Note that there'll be a future follow up to make the implementation more efficient in the future as well.

@Roasbeef Roasbeef closed this as completed Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features / behaviour feature request Requests for new features payments Related to invoices/payments rpc Related to the RPC interface
Projects
None yet
Development

No branches or pull requests

4 participants