Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing+invoices: implement AMP secret sharing and combination #3939

Closed
Roasbeef opened this issue Jan 21, 2020 · 1 comment
Closed

routing+invoices: implement AMP secret sharing and combination #3939

Roasbeef opened this issue Jan 21, 2020 · 1 comment
Assignees
Labels
advanced Issues suitable for very experienced developers amp crypto Related to the cryptography underlying LND enhancement Improvements to existing features / behaviour onion routing P1 MUST be fixed or reviewed payments Related to invoices/payments routing nodes routing
Milestone

Comments

@Roasbeef
Copy link
Member

Roasbeef commented Jan 21, 2020

This issue is related to lightning/bolts#658. Completion of this issue entails creating a new secretshare package (naming suggestion) within lnd that's able to:

  • Statically create a set of N shares for apriori splitting use cases.
  • Dynamically create a set of N shares (incrementally or adaptively) fo more adhoc splitting use case.
  • Combine the relevant shares and perform key derivation to produce preimages and payment hashes related to an ultimate payment

Once the above is done (the libraries at the edges), we'll also need to then integrate this new combination logic into the invoice registry. Along the way we'll likely opt to create some sort of new HTLC combination+settling (deciding when it's possible to combine and also how to derive the pre-images) within the invoice registry.

I've left out most of the details w.r.t the additive secret sharing scheme as those are elaborated upon in detail within the linked issue. One other thing I've left out of this is the implication on the RPC interface, for calls such as ListPayments and ListInvoices.

@Roasbeef Roasbeef added enhancement Improvements to existing features / behaviour onion routing crypto Related to the cryptography underlying LND advanced Issues suitable for very experienced developers routing payments Related to invoices/payments routing nodes labels Jan 21, 2020
@Roasbeef Roasbeef added this to the 0.10.0 milestone Jan 21, 2020
@Roasbeef Roasbeef modified the milestones: 0.10.0, 0.11.0 Mar 10, 2020
@cfromknecht cfromknecht removed the v0.11 label Jun 17, 2020
@cfromknecht cfromknecht removed this from the 0.11.0 milestone Jun 17, 2020
@Roasbeef Roasbeef added this to the 0.13.0 milestone Mar 5, 2021
@Roasbeef Roasbeef added the P1 MUST be fixed or reviewed label Mar 5, 2021
@Roasbeef Roasbeef added the amp label Apr 8, 2021
@cfromknecht
Copy link
Contributor

Closed by #4162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced Issues suitable for very experienced developers amp crypto Related to the cryptography underlying LND enhancement Improvements to existing features / behaviour onion routing P1 MUST be fixed or reviewed payments Related to invoices/payments routing nodes routing
Projects
None yet
Development

No branches or pull requests

2 participants