Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-integer needs a rewrite #191

Open
2 tasks
cyrilbouvier opened this issue Dec 7, 2021 · 0 comments
Open
2 tasks

test-integer needs a rewrite #191

cyrilbouvier opened this issue Dec 7, 2021 · 0 comments
Labels
enhancement

Comments

@cyrilbouvier
Copy link
Member

cyrilbouvier commented Dec 7, 2021 •
edited by ClementPernet
Loading

The test test-integer needs to be rewritten to be more thorought, it fails to catch two bugs (found and fixed in PR #190).

  • The function test_divmod should be rewritten to check all possible signedness for the input.
  • The function test_cast should be rewritten to check the specific case of casting to a signed type when the input is too large to fit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cyrilbouvier